-
Notifications
You must be signed in to change notification settings - Fork 104
chore: Use default protocol version in tests #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines how protocol versions are managed within the codebase, particularly in test environments. By linking a key specification version constant to a dynamic source and removing redundant explicit version settings in various handler tests, the changes promote a more robust and adaptable system. This ensures that tests automatically align with the current default protocol version, reducing the need for manual updates when the default changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the codebase to rely on the default protocol version from AgentCard.CURRENT_PROTOCOL_VERSION instead of hardcoding "1.0", which is a good improvement for maintainability. The changes in the test files correctly remove the explicit version setting, simplifying the test setup. I have one suggestion regarding the naming of a constant in Utils.java to improve clarity and prevent potential confusion in the future.
| * Specification version constant for deprecation annotations. | ||
| */ | ||
| public static final String SPEC_VERSION_1_0 = "1.0"; | ||
| public static final String SPEC_VERSION_1_0 = AgentCard.CURRENT_PROTOCOL_VERSION; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's a good practice to use AgentCard.CURRENT_PROTOCOL_VERSION to avoid hardcoding the version string, the constant name SPEC_VERSION_1_0 is now misleading. It implies the value is always "1.0", but it will change if AgentCard.CURRENT_PROTOCOL_VERSION is ever updated. This could lead to confusion for future maintainers.
To improve clarity and maintainability, please consider renaming this constant to reflect that it represents the current specification version, for example, CURRENT_SPEC_VERSION.
| public static final String SPEC_VERSION_1_0 = AgentCard.CURRENT_PROTOCOL_VERSION; | |
| public static final String CURRENT_SPEC_VERSION = AgentCard.CURRENT_PROTOCOL_VERSION; |
No description provided.