Skip to content

fix: fix flaky test testNonBlockingWithMultipleMessages #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmtoan wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

fix: fix flaky test testNonBlockingWithMultipleMessages #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tests/server-common/src/test/java/io/a2a/server/apps/common/AbstractA2AServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,9 +1274,11 @@ public void testDeletePushNotificationConfigSetWithoutConfigId() throws Exceptio
@Test
@Timeout(value = 1, unit = TimeUnit.MINUTES)
public void testNonBlockingWithMultipleMessages() throws Exception {
String multiEventTaskId = "multi-event-test-" + java.util.UUID.randomUUID();
try {
// 1. Send first non-blocking message to create task in WORKING state
Message message1 = Message.builder(MESSAGE)
.taskId("multi-event-test")
.taskId(multiEventTaskId)
.contextId("test-context")
.parts(new TextPart("First request"))
.build();
Expand All @@ -1301,7 +1303,7 @@ public void testNonBlockingWithMultipleMessages() throws Exception {
assertTrue(firstTaskLatch.await(10, TimeUnit.SECONDS));
String taskId = taskIdRef.get();
assertNotNull(taskId);
assertEquals("multi-event-test", taskId);
assertEquals(multiEventTaskId, taskId);

// 2. Resubscribe to task (queue should still be open)
CountDownLatch resubEventLatch = new CountDownLatch(2); // artifact-2 + completion
Expand Down Expand Up @@ -1337,7 +1339,7 @@ public void testNonBlockingWithMultipleMessages() throws Exception {

// 3. Send second streaming message to same taskId
Message message2 = Message.builder(MESSAGE)
.taskId("multi-event-test") // Same taskId
.taskId(multiEventTaskId) // Same taskId
.contextId("test-context")
.parts(new TextPart("Second request"))
.build();
Expand Down Expand Up @@ -1411,6 +1413,9 @@ public void testNonBlockingWithMultipleMessages() throws Exception {
assertEquals("artifact-2", streamArtifact.artifact().artifactId());
assertEquals("Second message artifact",
((TextPart) streamArtifact.artifact().parts().get(0)).text());
} finally {
deleteTaskInTaskStore(multiEventTaskId);
}
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion tests/server-common/src/test/java/io/a2a/server/apps/common/AgentExecutorProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public void execute(RequestContext context, EventQueue eventQueue) throws A2AErr
String taskId = context.getTaskId();

// Special handling for multi-event test
if ("multi-event-test".equals(taskId)) {
if (taskId != null && taskId.startsWith("multi-event-test")) {
// First call: context.getTask() == null (new task)
if (context.getTask() == null) {
updater.startWork();
Expand Down