rp2xxx: Fix Adafruit boards#960
Open
Grazfather wants to merge 1 commit into
Open
Conversation
I noticed that my Adafruit Feather rp2350 worked when I first flashed it, but not after a reset or power cycle. Digging through some code, I found a commit that added support for the Adafruit Feather to the arduino-pico core: earlephilhower/arduino-pico@163b209d#diff-d0d48a8d47fd5d31e3bc70b12159bdcb23a5ab82460bb5972cf61776f4d6768aR34-R42 It sets `PICO_XOSC_STARTUP_DELAY_MULTIPLIER=64`. Seems that these boards have shakier clocks. This change adds support for an optional `xosc_startup_delay_multiplier`, which increases the startup_delay_ms when setting up the external oscillator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that my Adafruit Feather rp2350 worked when I first flashed it, but not after a reset or power cycle.
Digging through some code, I found a commit that added support for the Adafruit Feather to the arduino-pico core:
earlephilhower/arduino-pico@163b209d#diff-d0d48a8d47fd5d31e3bc70b12159bdcb23a5ab82460bb5972cf61776f4d6768aR34-R42
It sets
PICO_XOSC_STARTUP_DELAY_MULTIPLIER=64.Seems that these boards have shakier clocks.
This change adds support for an optional
xosc_startup_delay_multiplier, which increases the startup_delay_ms when setting up the external oscillator.