Merged
Conversation
This is done to fix a known bug in lwIP that caused a null pointer dereference. Source: https://savannah.nongnu.org/bugs/?59831
This function helps identify improper use of lwIP functions in multi-threaded environments, like forgetting to lock the core mutex
mattnite
approved these changes
Feb 13, 2026
mattnite
approved these changes
Feb 13, 2026
tact1m4n3
approved these changes
Feb 13, 2026
Collaborator
tact1m4n3
left a comment
tact1m4n3
left a comment
There was a problem hiding this comment.
Nice! Thank you! I think the merge to main broke the examples (the assert import in exports.zig was removed). After CI passes we can merge.
Grazfather
approved these changes
Feb 13, 2026
Contributor
Author
|
Oops! Thanks for telling me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, lwIP caused null pointer dereferences in my setup (see this).
It was also possible to use APIs that expected the core mutex to be locked without locking it.
Now it will instead panic, letting you know.
My project is now much more stable, and I haven't encountered any crashes.