Fix MCP setup script: Resolve "Terminated" error during Playwright verification#184
Draft
codegen-sh[bot] wants to merge 1 commit intodevelopfrom
Draft
Fix MCP setup script: Resolve "Terminated" error during Playwright verification#184codegen-sh[bot] wants to merge 1 commit intodevelopfrom
codegen-sh[bot] wants to merge 1 commit intodevelopfrom
Conversation
- Replace 'which playwright' with proper npm package verification - Replace 'which context7-mcp' with npm list check - Add comprehensive verification script for all MCP servers - Create mcp.json.template with correct server configurations - Add detailed MCP_SETUP.md documentation - Improve error handling and user feedback - Add color-coded output for better readability Fixes 'Terminated' error that occurs during setup when verification commands fail. The issue was that 'playwright' is not a standalone command but is invoked via 'npx @playwright/mcp'. Files added: - scripts/setup_mcp_fixed.sh: Fixed setup script - scripts/verify_mcp_setup.sh: Comprehensive verification tool - config/mcp.json.template: Ready-to-use configuration - docs/MCP_SETUP.md: Complete setup and troubleshooting guide Co-authored-by: Zeeeepa <zeeeepa@gmail.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem
The MCP setup script was failing with a "Terminated" error during the Playwright installation verification step. The script used
which playwrightto verify installation, butplaywrightis not a standalone command—it's invoked vianpx @playwright/mcp.✅ Solution
This PR replaces the failing verification logic with proper npm package checks and adds comprehensive tooling for MCP setup.
Changes Made
1. Fixed Setup Script (
scripts/setup_mcp_fixed.sh)which playwrightwithnpm list -g @playwright/mcp --depth=0which context7-mcpwithnpm list -g @upstash/context7-mcp --depth=02. Verification Script (
scripts/verify_mcp_setup.sh)3. MCP Configuration Template (
config/mcp.json.template)4. Complete Documentation (
docs/MCP_SETUP.md)🧪 Testing
Run the verification script to test your MCP setup:
Expected output:
📦 Files Added/Modified
🔧 How to Use
Run the fixed setup script:
Verify installation:
Copy configuration to your MCP client:
cp config/mcp.json.template ~/.config/Claude/mcp.jsonRestart your MCP client
📖 Documentation
See
docs/MCP_SETUP.mdfor:✨ Benefits
Fixes the issue where
which playwrightcauses script termination because Playwright MCP is not a standalone binary but is invoked vianpx @playwright/mcp.💻 View my work • 👤 Initiated by @Zeeeepa • About Codegen
⛔ Remove Codegen from PR • 🚫 Ban action checks
Summary by cubic
Fixes the MCP setup crash caused by using which playwright by switching to npm-based checks, and adds tools to verify and configure MCP servers. This removes the "Terminated" error and makes setup reliable for Playwright, Context7, and Codegen.
Bug Fixes
New Features
Written for commit 6ba8440. Summary will update automatically on new commits.