fix: Add support for custom test command. #44
Merged
thelukewalton merged 4 commits intomainfrom Apr 11, 2025
Merged
Conversation
… pass 'melos test' from the zeta_flutter monorepo
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/scripts/runTests.ts:13
- Consider using a consistent name for the coverage directory parameter across the codebase (e.g., 'coverageDir' vs 'coverageDirectory' vs 'COVERAGE_DIR') to improve clarity.
export const getTest = async (coverageDir: string, testCommand: string): Promise<stepResponse> => {
README.md:45
- [nitpick] The documentation note regarding 'coverageDir' might be confusing. Consider clarifying that when a custom test-command is provided, the default coverage path is not automatically applied and users should ensure the test command handles coverage accordingly.
Test command is empty by default, and the command used is: `flutter test --coverage --reporter json --coverage-path ${coverageDir}/lcov.info`. This whole string is replaced with the content of test-command, so it is important to consider that `coverageDir` is not provided.
deps: Move to yarn for package management ci: Update pull request for new changes
DE7924
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done so that we can pass 'melos test' from the zeta_flutter monorepo