Fix RTL margin handling in group component#25
Conversation
I had made a mistake previously by putting the RTL margin styles one level higher than where it belonged.
|
Looks good! Thanks for the RTL updates as well, its much appreciated and helps a lot! Do you work with RTL styling often? I haven't done any RTL styling before, and kind of understand it, but it would be great to have someone that understands it better than I do, to ensure compatibility with those languages. |
|
Thank you for the feedback and for maintaining this project. I appreciate your kind words 😃 I've worked on RTL styling in the past, although it's not a regular part of my current projects. I'm happy to help ensure compatibility with RTL languages as much as I can. Please let me know if there's anything specific I can assist with. |
|
Hey @remohammadi I grabbed a pull request from the original PicoCSS project picocss/pull/599 and made a pull request here for it #27, but I know it would need to be updated as well for some newer features that been added. Would you mind possibly doing a find/replace within the scss directory to update that to use the logical properties for better RTL support? You can make a new pull request if you're able to do that for us! If not its cool, I'll get to it probably next week after I finish this project for a client. |
I had made a mistake previously by putting the RTL margin styles one level higher than where it belonged.