AIESW-21881 : Fix ctrl scratchpad memory creation bug #9527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Bramandlapalli <rbramand@amd.com>
larry9523
approved these changes
Jan 7, 2026
chvamshi-xilinx
approved these changes
Jan 7, 2026
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
|
While @rbramand-xilinx is working on verification on silicon, I did managed to verify the fix on Simnow. Without the fix, the ctrl scratchpad memory is allocated from the host only buffer. But with the fix, it is allocated from the device SRAM. So I merge this PR now |
rbramand-xilinx
added a commit
to rbramand-xilinx/XRT
that referenced
this pull request
Jan 9, 2026
Signed-off-by: Rahul Bramandlapalli <rbramand@amd.com> (cherry picked from commit f456d57)
chvamshi-xilinx
pushed a commit
that referenced
this pull request
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Added correct flag when creating control scratchpad memory to create cacheable buffer instead of host buffer
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
PR - #9373 introduced the bug when trying to add separate flags for scratchpad and ctrl scratchpad as one requires host buffer and other requires cacheable buffer.
How problem was solved, alternative solutions (if any) and why they were rejected
Using correct flag when creating ctrl scratchpad so that cacheable memory is created.
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
TODO : Need to test the bug reported, this PR is added so that it can be used for compilation and testing
Documentation impact (if any)
Low