Improve breaking change test detection #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PETOSS-877 |
|
Thanks for raising an issue, a ticket has been created to track your request |
rpocklin
force-pushed
the
break-change-test
branch
3 times, most recently
from
5a9bcee to
0de59bf
Compare
rpocklin
changed the title
also fail on warnings
rpocklin
force-pushed
the
break-change-test
branch
from
0de59bf to
3c703e0
Compare
the-chris-mitchell
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous actual test scenario here did not identify the breaking change due to a PR being on a forked branch.
This is a follow up PR to fix that branch detection / comparison issue and demonstrate it with a failing commit (not being on a branch containing
breaking-change). I expect the github workflows to initially fail on this branch. That demonstrates it works as expected and I will remove that commit before this gets merged - see failed job hereI have now removed the breaking schema change from this PR and is ready for review.