feat!: remove deprecated NZ fields NZP-5360 #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: remove deprecated fields SickLeaveHoursToAccrueAnnually -> SickLeaveToAccrueAnnually, SickLeaveMaximumHoursToAccrue -> SickLeaveMaximumToAccrue, HoursAccruedAnnually -> UnitsAccruedAnnually These fields have been disconnected in the backend for some time so safe to remove update incorrect description for rateAccruedHourly on NZ employee leave type
|
PETOSS-860 |
|
Thanks for raising an issue, a ticket has been created to track your request |
Contributor
|
Hey @Xero-Chris-Lelievre, I've just had a look at this one, and it turns out there are tests in XeroAPI/Xero-Java that depend on some of these fields. Could you please raise a PR there to remove those before we proceed with this. |
Xero-Chris-Lelievre
changed the title
Contributor
Author
|
Plan to squash-merge this, so we get the updated "feat" in the commit :) |
pj-jacobs
approved these changes
Nov 20, 2025
the-chris-mitchell
approved these changes
Nov 25, 2025
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE: remove deprecated fields SickLeaveHoursToAccrueAnnually -> SickLeaveToAccrueAnnually, SickLeaveMaximumHoursToAccrue -> SickLeaveMaximumToAccrue, HoursAccruedAnnually -> UnitsAccruedAnnually These fields have been disconnected in the backend for some time so safe to remove
update incorrect description for rateAccruedHourly on NZ employee leave type
NZP-5360