Skip to content

[PETOSS-829] Update codegen app_id location #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
the-chris-mitchell merged 2 commits into from
Oct 28, 2025
Merged

[PETOSS-829] Update codegen app_id location #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3d1707
[PETOSS-829] Use var for app_id as per docs
the-chris-mitchell Oct 28, 2025
b42f601
[PETOSS-829] Replace access token action
the-chris-mitchell Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions .github/workflows/create-github-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,12 @@ jobs:

- name: Get github app access token
id: get_access_token
env:
GITHUB_APP_ID: ${{ secrets.XERO_GITHUB_APP_ID }}
GITHUB_APP_PRIVATE_KEY: ${{ secrets.XERO_GITHUB_APPLICATION_KEY }}
uses: actions/github-script@v7
uses: actions/create-github-app-token@v2
with:
result-encoding: string
script: |
const { getAccessToken } = await import('${{ github.workspace }}/.github/get-access-token/index.js')
const token = await getAccessToken()
return token
app-id: ${{ secrets.XERO_PUBLIC_BOT_APP_ID}}
private-key: ${{ secrets.XERO_PUBLIC_BOT_KEY }}
owner: xero-internal
repositories: xeroapi-sdk-codegen

- name: Fetch Latest release number
id: get_latest_release_number
Expand All @@ -41,7 +37,7 @@ jobs:
echo "Latest release version is - $latest_version"
echo "releaseVersion=$latest_version" >> $GITHUB_OUTPUT
env:
GH_TOKEN: ${{steps.get_access_token.outputs.result}}
GH_TOKEN: ${{steps.get_access_token.outputs.token}}

- name: Set up branch name
id: identify_branch_name
Expand Down Expand Up @@ -121,4 +117,4 @@ jobs:
echo "PR is already up to date"
fi
env:
GH_TOKEN: ${{steps.get_access_token.outputs.result}}
GH_TOKEN: ${{steps.get_access_token.outputs.token}}
2 changes: 1 addition & 1 deletion .github/workflows/pr-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
id: get_access_token
uses: actions/create-github-app-token@v2
with:
app-id: ${{ secrets.XERO_GITHUB_APP_ID }}
app-id: ${{ vars.XERO_CODEGEN_APP_ID }}
private-key: ${{ secrets.XERO_GITHUB_APPLICATION_KEY }}
owner: xero-internal
repositories: xeroapi-sdk-codegen
Expand Down
Loading