Add sourceURL comments for directly constructed inline scripts in wp-includes

[westonruter]

I realized in https://github.com/WordPress/wordpress-develop/pull/9531/files#r2361414013 that that the emoji loader script wasn't geting the sourceURL comment. I then realized that there were more than a dozen other such instances of scripts constructed via wp_get_inline_script_tag() and wp_print_inline_script_tag() in wp-includes which lacked these comments.

Note that there are quite a few scripts constructed in wp-admin which are not yet using wp_get_inline_script_tag() and wp_print_inline_script_tag(). See Core-59446.

There are also instances of inline scripts being printed in themes which this PR does not address. I've suggested that these be handled as part of Core-63806.

• Upstream block change to Gutenberg. See Categories block: Improve and harden JavaScript used when displayed as dropdown gutenberg#72118

Trac ticket: https://core.trac.wordpress.org/ticket/63887

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[westonruter]

I realize this change will need to be done upstream in Gutenberg.

[westonruter]

See WordPress/gutenberg#72118

[sirreal]

Let's pass all of these through rawurlencode() rather than any string replacement or otherwise relying on the strings to be safe.

That's how it's implemented in script loader:

wordpress-develop/src/wp-includes/script-loader.php

Line 2215 in 3c3852e

echo sprintf( "\n//# sourceURL=%s\n", rawurlencode( 'js-inline-concat-' . $concat ) );

The spec says this:

Note: is a URL as defined in RFC3986; in particular, characters outside the set permitted to appear in URIs must be percent-encoded.

And rawurlencode() is just the thing:

Encodes the given string according to » RFC 3986.

[westonruter]

Note how the function now shows up in the coverage report:

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter, jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[sirreal]

I've tested several but not all of these cases. I have reviewed all the changes and they appear correct.

It's a very nice improvement when errors or logs come from these scripts 👍

[sirreal]

Have you or are you planning to create a PR for the case that comes from Gutenberg?

[westonruter]

Have you or are you planning to create a PR for the case that comes from Gutenberg?

@sirreal Thanks for the reminder: WordPress/gutenberg#72118

[westonruter]

Committed in r60909 (8c2ec29)