fix: incorrect array access to template_name property in get_taxonomy_labels()#7720
fix: incorrect array access to template_name property in get_taxonomy_labels()#7720justlevine wants to merge 1 commit intoWordPress:trunkfrom
template_name property in get_taxonomy_labels()#7720Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Not sure why this is breaking things. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
af20a3a to
f35462d
Compare
|
On further investigation, this is invalid, and labels is indeed reconverted back to an object. |
Trac ticket:
https://core.trac.wordpress.org/ticket/64238
https://core.trac.wordpress.org/ticket/63268
This PR fixes an issue in
get_taxonomy_labels(), where thetemplate_namewas accessed as an object property on$tax->labelsinstead of as an array property.While this issue was surfaced via PHPStan in #7619 (trac: https://core.trac.wordpress.org/ticket/61175 ), it can be remediated independently of that ticket.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.