fix: WP_Styles::get_etag() should only take $load parameter#7715
fix: WP_Styles::get_etag() should only take $load parameter#7715justlevine wants to merge 1 commit intoWordPress:trunkfrom
$load parameter#7715Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Nice catch @justlevine, @SergeyBiryukov could you please take a look. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Committed in https://core.trac.wordpress.org/changeset/59341 |
Trac ticket: https://core.trac.wordpress.org/ticket/52217
This PR fixes an issue with the usage of the new
$wp_style->get_etag()inload-styles.php, where the$wp_versionis passed as the first arg instead of$loadbeing used as the only arg.While this issue was surfaced via PHPStan in #7619 (trac: https://core.trac.wordpress.org/ticket/61175 ), it should be remediated independently of that issue as it's a novel bug getting shipped in WP 6.7
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.