chore: fix invalid @var type for WP_HTML_Processor_State::$context_node#7685
chore: fix invalid @var type for WP_HTML_Processor_State::$context_node#7685justlevine wants to merge 1 commit intoWordPress:trunkfrom
@var type for WP_HTML_Processor_State::$context_node#7685Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Closing, as this is deprecated in 6.8 |
Trac ticket: https://core.trac.wordpress.org/ticket/52217
This PR fixes the PHPDoc
@vartype used forWP_HTML_Processor_State::$context_nodeto "correctly" indicate that it is an array where the first item is astringand the second is anarray."Correctly" in this context means recognized by IDEs and tooling and following preexisting code patterns for array shapes (e.g.
wordpress-develop/src/wp-includes/interactivity-api/class-wp-interactivity-api.php
Line 104 in 695476e
While this issue was surfaced via PHPStan in #7619 (trac: https://core.trac.wordpress.org/ticket/61175 ), it can be remediated independently of that ticket.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.