Fix: use explicit returns in WP_Site_Health_Auto_Updates::test_*() methods#7675
Fix: use explicit returns in WP_Site_Health_Auto_Updates::test_*() methods#7675justlevine wants to merge 3 commits intoWordPress:trunkfrom
Conversation
…thods. Since these methods are public, `null` is used to represent a passed test for backwards-compatibility with a coreced void. Previous usage of `false` is preserved.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
apermo
left a comment
There was a problem hiding this comment.
See comment.
From a technical point of view all good, just the doc thing feels wrong.
|
Thanks for the PR! Merged in r59340. |
Trac ticket: https://core.trac.wordpress.org/ticket/52217
This PR fixes several instances of
WP_Site_Health_Auto_Updates::test_*()potentially returningvoidinstead of their documented return types.Since these methods are public for some reason,
nullis used to represent a passed test for backwards-compatibility with the coersion of the previously-returnedvoids. Previous usage offalseis preserved.While this issue was surfaced via PHPStan in #7619 (trac: https://core.trac.wordpress.org/ticket/61175 ), it can be remediated independently of that ticket.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.