Skip to content

Admin bar: replace home dashicon with actual site icon if set#11781

Open
fushar wants to merge 1 commit intoWordPress:trunkfrom
fushar:admin-bar-site-icon
Open

Admin bar: replace home dashicon with actual site icon if set#11781
fushar wants to merge 1 commit intoWordPress:trunkfrom
fushar:admin-bar-site-icon

Conversation

@fushar
Copy link
Copy Markdown

@fushar fushar commented May 9, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/65088

This PR replaces the home / odometer dashicon, with the actual site icon, if set, in the admin bar. The icon will be 20x20px, with border-radius of 2px and background-color of #f0f0f1.

If the site has not set site icon, then the default dashicons (home / odometer) is NOT changed.

Screenshot

Before

image image

After

image image image image image image image image image

Before (mobile)

image image

After (mobile)

image image

Use of AI Tools

I used Codex with GPT-5.5 to help with the CSS implementation, with my supervision.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

Hi @fushar! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@fushar fushar marked this pull request as ready for review May 9, 2026 07:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props fushar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fushar fushar force-pushed the admin-bar-site-icon branch from 1cb9759 to fd1099a Compare May 9, 2026 07:33
@fushar fushar force-pushed the admin-bar-site-icon branch from fd1099a to 646995d Compare May 9, 2026 07:40
@fushar fushar changed the title Admin bar: replace home dashicon with actua site icon if set Admin bar: replace home dashicon with actual site icon if set May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant