Skip to content

Connectors: Expose isFileModsDisabled to connector script module data#11779

Open
jorgefilipecosta wants to merge 3 commits intoWordPress:trunkfrom
jorgefilipecosta:add/connectors-file-mods-disabled-data
Open

Connectors: Expose isFileModsDisabled to connector script module data#11779
jorgefilipecosta wants to merge 3 commits intoWordPress:trunkfrom
jorgefilipecosta:add/connectors-file-mods-disabled-data

Conversation

@jorgefilipecosta
Copy link
Copy Markdown
Member

@jorgefilipecosta jorgefilipecosta commented May 8, 2026

Summary

  • Adds isFileModsDisabled (derived from wp_is_file_mod_allowed( 'install_plugins' )) to the data exposed through the script_module_data_options-connectors-wp-admin filter so the connectors UI can react when plugin installs are disabled.

Ticket: https://core.trac.wordpress.org/ticket/65209

Test plan

  • Load the connectors admin screen and verify isFileModsDisabled is present on the script module data with the expected value.
  • Toggle file mods off (e.g. define( 'DISALLOW_FILE_MODS', true )) and confirm the value flips to true.

Adds an `isFileModsDisabled` flag derived from `wp_is_file_mod_allowed( 'install_plugins' )` to the data exposed via the `script_module_data_options-connectors-wp-admin` filter so the UI can react when plugin installs are disabled.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorgefilipecosta, westonruter, jeffpaul.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@jeffpaul
Copy link
Copy Markdown
Member

jeffpaul commented May 8, 2026

@jorgefilipecosta is there a trac ticket for this / is this targeted for 7.0?

@jorgefilipecosta
Copy link
Copy Markdown
Member Author

@jorgefilipecosta is there a trac ticket for this / is this targeted for 7.0?

Hi @jeffpaul, yes it will go with 7.0 it is a backport of WordPress/gutenberg#77521. Ticket is available at https://core.trac.wordpress.org/ticket/65209.

@jorgefilipecosta
Copy link
Copy Markdown
Member Author

cc: @t-hamano, @westonruter as reviewers of WordPress/gutenberg#77521 would you be able to review / sign this one. Thank you in advance.

Copy link
Copy Markdown
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@jorgefilipecosta
Copy link
Copy Markdown
Member Author

Thank you @westonruter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants