Skip to content

Add unit tests for wp_check_php_version() in wp-admin/includes/misc.php#11764

Open
pbearne wants to merge 2 commits intoWordPress:trunkfrom
pbearne:65203-misc-wp_check_php_version
Open

Add unit tests for wp_check_php_version() in wp-admin/includes/misc.php#11764
pbearne wants to merge 2 commits intoWordPress:trunkfrom
pbearne:65203-misc-wp_check_php_version

Conversation

@pbearne
Copy link
Copy Markdown

@pbearne pbearne commented May 7, 2026

Description:
This PR adds unit tests for the wp_check_php_version() function in wp-admin/includes/misc.php. These tests ensure that WordPress correctly checks the active PHP version against the Serve Happy API, handles API failures gracefully, manages caching via site transients, and correctly enforces minimum version requirements.

The tests cover:

  • Handling of API failures (returning false).
  • Verification of the response structure and data on API success.
  • Verification that API results are correctly cached in site transients.
  • Verification that cached results are used in subsequent calls.
  • Verification of the wp_is_php_version_acceptable filter.
  • Verification of future minimum version logic (ensuring PHP versions below 8.0 are marked as unacceptable).

Trac ticket: https://core.trac.wordpress.org/ticket/65203

AI Disclosure:

  • AI assistance: Yes
  • Tool(s): Junie (JetBrains)
  • Model(s): gemini-3-flash-preview
  • Used for: Code analysis, test implementation, and workflow management.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant