Skip to content

Plugins: Update custom view counts when deleting a plugin.#11752

Open
andreas-pa wants to merge 1 commit intoWordPress:trunkfrom
andreas-pa:fix/plugins-list-status-text-delete-counts
Open

Plugins: Update custom view counts when deleting a plugin.#11752
andreas-pa wants to merge 1 commit intoWordPress:trunkfrom
andreas-pa:fix/plugins-list-status-text-delete-counts

Conversation

@andreas-pa
Copy link
Copy Markdown

@andreas-pa andreas-pa commented May 7, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/65191

Decrements counts for groups registered via the plugins_list filter when a plugin is deleted via AJAX, so tabs whose label is supplied through plugins_list_status_text (introduced in #60495) stay in sync without requiring a page reload. The four hardcoded buckets (upgrade, inactive, active, recently_activated) plus auto-update-enabled / auto-update-disabled keep their explicit fast paths; the new loop only runs for keys outside that set.

Reproduction

See the steps in Trac #65191. TL;DR: register a group via plugins_list with a label supplied through plugins_list_status_text, delete a plugin in that group via the row action, and observe the count badge stay stale until reload.

Test plan

  • Hardcoded tabs (Active, Inactive, Update available) still decrement on delete.
  • Custom group registered via plugins_list: count drops on delete; tab disappears at zero.
  • Sites with no custom groups: no behavior change.

…uginSuccess.

  Decrement counts for groups registered via the plugins_list filter when
  a plugin is deleted via AJAX, so tabs whose label is supplied through
  plugins_list_status_text (introduced in #60495) stay in sync without a
  page reload.

  See #65191.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @andreas-am.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Hi @andreas-pa! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@andreas-pa andreas-pa changed the title Administration: maintain custom plugins_list group counts in deletePl… Plugins: Update custom view counts when deleting a plugin. May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants