Formatting: Skip readonly properties in map_deep() to prevent fatal errors on PHP 8.1+#11334
Draft
himanshupathak95 wants to merge 1 commit intoWordPress:trunkfrom
Draft
Formatting: Skip readonly properties in map_deep() to prevent fatal errors on PHP 8.1+#11334himanshupathak95 wants to merge 1 commit intoWordPress:trunkfrom
map_deep() to prevent fatal errors on PHP 8.1+#11334himanshupathak95 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
…rrors on PHP 8.1+.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/60355
On PHP 8.1+, passing an object with
readonlyproperties throughmap_deep()causes a fatal error because the function attempts to reassign every property after applying the callback.This affects any code path that stores objects in metadata, since
update_metadata()→wp_unslash()→stripslashes_deep()callsmap_deep()internally.This PR adds a
PHP_VERSION_ID >= 80100guard insidemap_deep()that usesReflectionProperty::isReadOnly()to detect and skip readonly properties.WIP: Will be adding unit tests for this shortly.