Skip to content

Formatting: Skip readonly properties in map_deep() to prevent fatal errors on PHP 8.1+#11334

Draft
himanshupathak95 wants to merge 1 commit intoWordPress:trunkfrom
himanshupathak95:fix/60355
Draft

Formatting: Skip readonly properties in map_deep() to prevent fatal errors on PHP 8.1+#11334
himanshupathak95 wants to merge 1 commit intoWordPress:trunkfrom
himanshupathak95:fix/60355

Conversation

@himanshupathak95
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/60355

On PHP 8.1+, passing an object with readonly properties through map_deep() causes a fatal error because the function attempts to reassign every property after applying the callback.

This affects any code path that stores objects in metadata, since update_metadata()wp_unslash()stripslashes_deep() calls map_deep() internally.

This PR adds a PHP_VERSION_ID >= 80100 guard inside map_deep() that uses ReflectionProperty::isReadOnly() to detect and skip readonly properties.

WIP: Will be adding unit tests for this shortly.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant