Skip to content

Fix #64931 - duplicate filename display in media upload errors #11332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Presskopp wants to merge 1 commit into
base: trunk
Choose a base branch
from
+5 −3
Open

Fix #64931 - duplicate filename display in media upload errors #11332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/js/_enqueues/vendor/plupload/wp-plupload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,10 @@ window.wp = window.wp || {};
'SECURITY_ERROR': pluploadL10n.security_error,

'FILE_SIZE_ERROR': function( file ) {
return pluploadL10n.file_exceeds_size_limit.replace( '%s', file.name );
return pluploadL10n.file_exceeds_size_limit.replace(
'%s',
'<strong>' + _.escape(file.name) + '</strong>'
);
},

'HTTP_ERROR': function( file ) {
Expand Down
3 changes: 1 addition & 2 deletions src/wp-includes/media-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,7 @@ function wp_print_media_templates() {

<?php // Template for the uploading status errors. ?>
<script type="text/html" id="tmpl-uploader-status-error">
<span class="upload-error-filename word-wrap-break-word">{{{ data.filename }}}</span>
<span class="upload-error-message">{{ data.message }}</span>
<span class="upload-error-message word-wrap-break-word">{{{ data.message }}}</span>
</script>

<?php // Template for the Attachment Details layout in the media browser. ?>
Expand Down
Loading