Skip to content

Remove tabindex on media library tabpanels #10884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joedolson wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Remove tabindex on media library tabpanels #10884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a08b64e
Remove tabindex on media library tabpanels
joedolson Feb 7, 2026
8b83524
Update src/js/media/views/media-frame.js
joedolson Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/js/media/views/media-frame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ MediaFrame = Frame.extend(/** @lends wp.media.view.MediaFrame.prototype */{
tabPanelEl = this.$el.find( '.media-frame-tab-panel' ),
ariaLabelledby;

tabPanelEl.removeAttr( 'role aria-labelledby tabindex' );
tabPanelEl.removeAttr( 'role aria-labelledby' );

if ( this.state().get( 'menu' ) && this.menuView && this.menuView.isVisible ) {
ariaLabelledby = 'menu-item-' + stateId;
Expand All @@ -111,7 +111,6 @@ MediaFrame = Frame.extend(/** @lends wp.media.view.MediaFrame.prototype */{
.attr( {
role: 'tabpanel',
'aria-labelledby': ariaLabelledby,
tabIndex: '0'
} );
}
},
Expand All @@ -127,7 +126,7 @@ MediaFrame = Frame.extend(/** @lends wp.media.view.MediaFrame.prototype */{
var tabPanelEl = this.$el.find( '.media-frame-content' ),
ariaLabelledby;

tabPanelEl.removeAttr( 'role aria-labelledby tabindex' );
tabPanelEl.removeAttr( 'role aria-labelledby' );

// Set the tab panel attributes only if the tabs are visible.
if ( this.state().get( 'router' ) && this.routerView && this.routerView.isVisible && this.content._mode ) {
Expand All @@ -137,7 +136,6 @@ MediaFrame = Frame.extend(/** @lends wp.media.view.MediaFrame.prototype */{
.attr( {
role: 'tabpanel',
'aria-labelledby': ariaLabelledby,
tabIndex: '0'
} );
}
},
Expand Down
Loading