Skip to content

Refine wp.sanitize.stripTags() when input is an empty value #10856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
westonruter wants to merge 4 commits into from
Closed

Refine wp.sanitize.stripTags() when input is an empty value #10856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
323af4b
Use non-strict equality check with null to cover undefined as well
westonruter Feb 3, 2026
6c902f0
Add edge cases for wp.sanitize.stripTags().
westonruter Feb 3, 2026
6b47ff8
Add test for boolean false in wp.sanitize.stripTags().
westonruter Feb 3, 2026
f7c8d79
Use falsy check in wp.sanitize.stripTags().
westonruter Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/_enqueues/wp/sanitize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
* @return {string} Stripped text.
*/
stripTags: function( text ) {
if ( null === text || 'undefined' === typeof text ) {
if ( ! text ) {
Copy link
Member

@sirreal sirreal Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's easier 😆

return '';
}

Expand Down
25 changes: 25 additions & 0 deletions tests/qunit/wp-includes/js/wp-sanitize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,31 @@ QUnit.test( 'stripTags should convert numbers to strings', function( assert ) {
assert.strictEqual( result, '123', 'stripTags( 123 ) should return "123"' );
} );

QUnit.test( 'stripTags should return empty string for input 0', function( assert ) {
const result = wp.sanitize.stripTags( 0 );
assert.strictEqual( result, '', 'stripTags( 0 ) should return ""' );
} );

QUnit.test( 'stripTags should return "0" for input "0"', function( assert ) {
const result = wp.sanitize.stripTags( '0' );
assert.strictEqual( result, '0', 'stripTags( "0" ) should return "0"' );
} );

QUnit.test( 'stripTags should return empty string for input false', function( assert ) {
const result = wp.sanitize.stripTags( false );
assert.strictEqual( result, '', 'stripTags( false ) should return ""' );
} );

QUnit.test( 'stripTags should return empty string for input NaN', function( assert ) {
const result = wp.sanitize.stripTags( NaN );
assert.strictEqual( result, '', 'stripTags( NaN ) should return ""' );
} );

QUnit.test( 'stripTags should return empty string for empty string input', function( assert ) {
const result = wp.sanitize.stripTags( '' );
assert.strictEqual( result, '', 'stripTags( "" ) should return ""' );
} );

QUnit.module( 'wp.sanitize.stripTagsAndEncodeText' );

QUnit.test( 'stripTagsAndEncodeText should return empty string for null input', function( assert ) {
Expand Down
Loading