Skip to content

Support directory relative references in esc_url() #10849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sabernhardt wants to merge 2 commits into
base: trunk
Choose a base branch
from
+12 −3
Open

Support directory relative references in esc_url() #10849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d183c2
Create unit tests
sabernhardt Feb 2, 2026
0810cb7
Changes from 46791-2.diff
sabernhardt Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/wp-includes/formatting.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4509,10 +4509,10 @@ function esc_url( $url, $protocols = null, $_context = 'display' ) {
/*
* If the URL doesn't appear to contain a scheme, we presume
* it needs http:// prepended (unless it's a relative link
* starting with /, # or ?, or a PHP file). If the first item
* in $protocols is 'https', then https:// is prepended.
* starting with ., /, # or ?, or a PHP file). If the first
* item in $protocols is 'https', then https:// is prepended.
*/
if ( ! str_contains( $url, ':' ) && ! in_array( $url[0], array( '/', '#', '?' ), true ) &&
if ( ! str_contains( $url, ':' ) && ! in_array( $url[0], array( '.', '/', '#', '?' ), true ) &&
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 Feb 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have but in core do we use similar pattern for retrieve the path?

! preg_match( '/^[a-z0-9-]+?\.php/i', $url )
) {
$scheme = ( is_array( $protocols ) && 'https' === array_first( $protocols ) ) ? 'https://' : 'http://';
Expand Down
9 changes: 9 additions & 0 deletions tests/phpunit/tests/formatting/escUrl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,4 +311,13 @@ public function test_ipv6_hosts() {
$this->assertSame( '//[::FFFF::127.0.0.1]/?foo%5Bbar%5D=baz', esc_url( '//[::FFFF::127.0.0.1]/?foo[bar]=baz' ) );
$this->assertSame( 'http://[::FFFF::127.0.0.1]/?foo%5Bbar%5D=baz', esc_url( 'http://[::FFFF::127.0.0.1]/?foo[bar]=baz' ) );
}

/**
* @ticket 46791
*/
public function test_directory_relative_references() {
$this->assertSame( './current-directory', esc_url( './current-directory' ) );
$this->assertSame( '../parent-directory', esc_url( '../parent-directory' ) );
$this->assertSame( '../../../../up-four-directories', esc_url( '../../../../up-four-directories' ) );
}
}
Loading