Media library 23562 #10832
Media library 23562 #10832
Conversation
Changes the current filter heading to be hidden using .screen-reader-text, changes the labels to be visible. Adds wrapper around the labels & inputs for filters for styling, updates styling to adapt for visible labels.
Allows voice command users to select images in the media library.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Practically speaking, I'd like to have this extend to other list table views, but I think that's overreach for this PR. |
|
|
||
| var filterContainer = wp.media.View.extend({ | ||
| tagname: 'div', | ||
| className: 'media-filter-container type-filter', |
There was a problem hiding this comment.
Why the new class type-filter added here?
| controller: this.controller, | ||
| model: this.controller.props, | ||
| priority: -80 |
2 participants
This pull request resolves the two major issues in the Media Library modal that block voice command users from being able to use the library, as described in the ticket.
Trac ticket: https://core.trac.wordpress.org/ticket/23562
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.