Media: Fix date filter not showing uploads in Media Library#10745
Media: Fix date filter not showing uploads in Media Library#10745rutviksavsani wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Changes
This PR implements two minimal changes to resolve the issue:
Add date filter functions (
src/js/media/models/attachments.js)Added
yearandmonthnumfilter functions to the staticAttachments.filtersobject (lines 598-657). These functions validate attachments against year/month filter criteriaUpdated allowed args whitelist (
src/js/media/models/query.js)Added
'year'and'monthnum'to theallowedargs array so Query collections observe the upload queue when date filters are active.Trac ticket: https://core.trac.wordpress.org/ticket/61057
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.