Editor: Add ARIA labels to LinkControl dialog#10708
Editor: Add ARIA labels to LinkControl dialog#10708Zaidfarooqui01 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Add accessibility improvements per Trac #63108: * Add role="dialog", aria-labelledby="link-dialog-title", and aria-modal="true" * Add hidden heading with id="link-dialog-title" and text "Insert Link" * Add aria-label="Link URL" to URL input field * Add aria-label="Search links" to search input field Fixes #63108. Props: Zaidfarooqui01 See: https://core.trac.wordpress.org/ticket/63108
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thanks for the PR! Unfortunately, this PR isn't acceptable because the |
Gutenberg/WordPress Core: Editor
Add accessibility improvements per Trac #64490:
role="dialog",aria-labelledby="link-dialog-title", andaria-modal="true"to LinkControl modal containerid="link-dialog-title"with text "Insert Link"aria-label="Link URL"to URLInput fieldaria-label="Search links"to search input fieldTested: Chrome Accessibility Tree + NVDA screen reader
Fixes #64490
Props: mohammadzaid
See: https://core.trac.wordpress.org/ticket/64490