Skip to content

Comments

Build: Reclassify json2php as a devDependency#10520

Open
RoyHridoy wants to merge 1 commit intoWordPress:trunkfrom
RoyHridoy:fix/json2php-dev-dep
Open

Build: Reclassify json2php as a devDependency#10520
RoyHridoy wants to merge 1 commit intoWordPress:trunkfrom
RoyHridoy:fix/json2php-dev-dep

Conversation

@RoyHridoy
Copy link

The json2php package is only used by the build process and is not required at runtime. It is even explicitly excluded from the runtime dependency unit test.

This change moves json2php from dependencies to devDependencies and regenerates the lockfile.

Trac ticket: Core-64221


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

Hi @RoyHridoy! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link

github-actions bot commented Nov 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @kmgalanakis.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props royhridoy, phpbits.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@RoyHridoy RoyHridoy force-pushed the fix/json2php-dev-dep branch from b3364e8 to d8d3798 Compare November 15, 2025 17:41
@westonruter westonruter requested a review from desrosj November 26, 2025 05:16
@kmgalanakis
Copy link

Hi @RoyHridoy

I've reviewed the code changes, and everything appears to be in order. Packages are getting installed properly, the build completes without any errors, and tests pass locally.

This is good to go.

Thank you

@phpbits
Copy link

phpbits commented Feb 10, 2026

Hi @RoyHridoy,

I also tested this branch, and the packages are installing correctly. I'm encountering these test errors locally, which may not be related to the changes here.

There were 86 warnings:

1) Tests_Actions::test_priority_callback_order with data set "float DESC" (array(10.0, 9.5), array('action2', 'action'), 'Implicit conversion from floa...cision')
Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.

/var/www/vendor/bin/phpunit:122

2) Tests_Actions::test_priority_callback_order with data set "float ASC" (array(9.5, 10.0), array('action', 'action2'), 'Implicit conversion from floa...cision')
Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.

/var/www/vendor/bin/phpunit:122

3) Tests_Admin_IncludesPost::test_post_exists_should_support_post_type
Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.

/var/www/vendor/bin/phpunit:122

4) Tests_Admin_IncludesPost::test_post_exists_should_not_match_a_page_for_post
Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.

/var/www/vendor/bin/phpunit:122

5) Tests_Admin_IncludesPost::test_post_exists_should_support_post_status
Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.

/var/www/vendor/bin/phpunit:122

Copy link
Member

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoyHridoy Thanks for this! Could you resolve the merge conflicts when you have a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants