Sync packages for WP 6.9 beta 3 by priethor · Pull Request #10453 · WordPress/wordpress-develop

priethor · 2025-11-03T12:10:30Z

Trac ticket: https://core.trac.wordpress.org/ticket/64185

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-11-03T12:10:42Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @deemkaaa09-lang.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props priethor, mukesh27, jeffpaul, westonruter, desrosj, wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

mukeshpanchal27 · 2025-11-03T14:17:32Z

src/wp-includes/blocks/archives.php

+ * @param string $dropdown_id ID of the dropdown field.
+ *
+ * @return string Returns the dropdown onChange redirection script.


Suggested change

* @param string $dropdown_id ID of the dropdown field.

*

* @return string Returns the dropdown onChange redirection script.

* @param string $dropdown_id ID of the dropdown field.

* @return string Returns the dropdown onChange redirection script.

What's the objective reason to remove the blank line? It passes the coding standard checks, and other PHPDocs in the same file have had the same blank line for years

I concur with @priethor here, no need to remove that line as most (all?) cases here include the line spacing (and at least for me makes it easier to read those docs/comments).

It's not a blocker but as per WordPress Inline Documentation Standards for PHP, there should not be an extra line between @param and @return tags.

I concur with @priethor here, no need to remove that line as most (all?) cases here include the line spacing (and at least for me makes it easier to read those docs/comments).

@jeffpaul In that case we should update the PHPCS document.

This can be done in a follow-up PR for Gutenberg, along with the change mentioned below.

Agreed that any such change should be done in Gutenberg, starting with updating the PHPCS rules to match the coding standards.

mukeshpanchal27 · 2025-11-03T14:18:36Z

src/wp-includes/blocks/archives.php

+	return wp_get_inline_script_tag(
+		trim( str_replace( array( '<script>', '</script>' ), '', ob_get_clean() ) ) .
+		"\n//# sourceURL=" . rawurlencode( __FUNCTION__ )
+	);


Should we use wp_remove_surrounding_empty_script_tags here? cc. @westonruter

Yes, although it's not important. It can be done in a follow-up PR to Gutenberg.

priethor · 2025-11-03T16:19:18Z

@desrosj, I see you are debugging the Windows build failures like in this PR. Is it a blocker to merge patches with failing workflows?

desrosj · 2025-11-03T17:19:20Z

@priethor I did create that PR to rule out a persisting cache as the reason for the failure. But I'm not actively investigating, mainly because I don't have a Windows machine.

This is similar to the other issue that happened earlier in the release. It's not a firm blocker, but anyone using Windows to contribute will potentially be unable to do so.

t-hamano · 2025-11-04T08:20:11Z

I see you are #10399 like in this PR. Is it a blocker to merge patches with failing workflows?

This issue was recently fixed in the Gutenberg repository: WordPress/gutenberg#72960

~~Will this fix be immediately reflected in the CI for the wordpress-develop repo?~~ Update: It seems that the Windows build issues have also been fixed in the CI for the wordpress-develop repo.

github-actions · 2025-11-04T08:47:31Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

priethor · 2025-11-04T12:04:54Z

I've done one last update before the Beta3 freeze, and it should be ready to go once GH actions pass.

Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/. Developed in #10453. See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches. Fixes #64185. Props priethor, mukesh27, jeffpaul, westonruter, desrosj, wildworks. git-svn-id: https://develop.svn.wordpress.org/trunk@61125 602fd350-edb4-49c9-b593-d223f7449a82

github-actions · 2025-11-04T12:35:14Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61125
GitHub commit: f3f8544

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/. Developed in WordPress/wordpress-develop#10453. See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches. Fixes #64185. Props priethor, mukesh27, jeffpaul, westonruter, desrosj, wildworks. Built from https://develop.svn.wordpress.org/trunk@61125 git-svn-id: http://core.svn.wordpress.org/trunk@60461 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/. Developed in WordPress/wordpress-develop#10453. See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches. Fixes #64185. Props priethor, mukesh27, jeffpaul, westonruter, desrosj, wildworks. Built from https://develop.svn.wordpress.org/trunk@61125 git-svn-id: https://core.svn.wordpress.org/trunk@60461 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Sync packages for wp 6.9 beta 3

eb70898

WordPress deleted a comment from github-actions bot Nov 3, 2025

mukeshpanchal27 reviewed Nov 3, 2025

View reviewed changes

This comment was marked as spam.

Sign in to view

Package sync

0ce58a9

ellatrix approved these changes Nov 4, 2025

View reviewed changes

github-actions bot closed this Nov 4, 2025

Comments

Conversation

priethor commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

priethor commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

desrosj commented Nov 3, 2025

Uh oh!

This comment was marked as spam.

t-hamano commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 4, 2025

Test using WordPress Playground

Some things to be aware of

Uh oh!

priethor commented Nov 4, 2025

Uh oh!

github-actions bot commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

github-actions bot commented Nov 3, 2025 •

edited

Loading

priethor commented Nov 3, 2025 •

edited

Loading

t-hamano commented Nov 4, 2025 •

edited

Loading