Swap out db-type and db-version for a more explicit db-image#10407
Draft
johnbillion wants to merge 9 commits intoWordPress:trunkfrom
Draft
Swap out db-type and db-version for a more explicit db-image#10407johnbillion wants to merge 9 commits intoWordPress:trunkfrom
db-type and db-version for a more explicit db-image#10407johnbillion wants to merge 9 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress.
This swaps out
db-typeanddb-versioninputs for a more explicitdb-imagewhich contains values such asmysql:8.0andmariadb:10.3.The idea behind this is that we can be more explicit about differences between supported versions of MySQL and MariaDB without having to maintain confusing
includeandexcluderules that are hard to read. As someone who is not overly familiar with the available versions of each of the two, I find the matrices confusing. This should help a lot.Trac ticket: https://core.trac.wordpress.org/ticket/63170