Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
||
| $this->assertNotEmpty( $output ); | ||
| $results = explode( "\n", trim( $output ) ); | ||
| $this->assertCount( 1, $results ); |
There was a problem hiding this comment.
Add assert check for post title also
There was a problem hiding this comment.
I'm not clear what you're asking for here. What do you think should be tested? Assert that the results contain the queried post title?
Adds wp.a11y.speak() on search results, clears results when no text.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
2 participants
Changes the menu quick search utility to only query the post_title column and adds a filter to enable previous functionality to be restored or customized.
Trac ticket: https://core.trac.wordpress.org/ticket/48655
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.