ContextHelper::is_in_function_call(): handle $valid_functions keys case-insensitively#2706
Merged
dingo-d merged 1 commit intoWordPress:developfrom Mar 5, 2026
Conversation
…se-insensitively The method already lowercased the token content before matching, but required callers to pass $valid_functions keys in lowercase. This normalizes the keys internally using array_change_key_case(), so callers no longer need to worry about passing lowercase function names.
dingo-d
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #2626 as discussed during code review.
The
ContextHelper::is_in_function_call()method already lowercased the token content before matching, but required callers to pass$valid_functionskeys in lowercase. This normalizes the keys internally usingarray_change_key_case(), so callers no longer need to worry about passing lowercase function names.Suggested changelog entry
ContextHelper::is_in_function_call(): the$valid_functionsparameter keys are now matched case-insensitively. Previously, keys had to be lowercase.Related issues/external references
Follow-up to #2626.