Conversation
Inspired by WordPress#289
Next up: test multiple files, request_multi See WordPress#289
…load # Conflicts: # src/Exception/File.php # src/File.php # src/Transport/Curl.php # src/Transport/Fsockopen.php # tests/Transport/Base.php # tests/phpunit.xml.dist
Added helper function Requests::add_files_to_body() to add files to body
Added helper function Requests::add_files_to_body() to add files to body
|
Why this still isn't merged? Such useful features... |
Member
|
@gdarko It's kind of hard to review code which is littered with unaddressed (automated) comments.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
This is a:
Context
Detailed Description
This is an update/refreshed version of https://github.com/soulseekah/Requests/tree/feature-upload
I have also added a helper function
Requests::add_files_to_body() to provide simplar way to add files to a body object
Quality assurance
Documentation
For new features:
examplesdirectory.docsdirectory.If the documentation is in a new markdown file, I have added a link to this new file to the Docs folder
README.mdfile.#289