Conversation
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
- Coverage 83.54% 83.49% -0.05%
==========================================
Files 26 26
Lines 2479 2484 +5
Branches 252 253 +1
==========================================
+ Hits 2071 2074 +3
- Misses 315 316 +1
- Partials 93 94 +1 |
|
There are some code formatting issues left. In case the pull request would allow edits (see https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests), the pre-commit.ci service would do the formatting for you... |
Okay let me check! |
I have pre commit installed already, it's passing the checks from my side but it fails on Git. |
|
You can ignore the DeepSource: Python errors, it sometimes fails to properly detect changes in the source and complains on errors which were present in the repository before. |
Okay, other than that all other checks managed to pass. Should i create the PR for previous fixes now? |
|
Merged, thanks for your contribution! We can now focus on getting #486 merged as well. |
|
Sorry, I meant #474... |
Proposed changes
Checklist
Other information