Conversation
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 83.31% 83.31% -0.01%
==========================================
Files 27 26 -1
Lines 2482 2475 -7
Branches 253 250 -3
==========================================
- Hits 2068 2062 -6
Misses 321 321
+ Partials 93 92 -1 |
File formatting fix
| <div class="clear"></div> | ||
| <a href="https://hosted.weblate.org/projects/" class="button border small rev inline" target="_blank">{% trans "See all projects" %}</a> | ||
| <a href="{% url 'donate' %}#thanks" class="button border small rev inline">{% trans "See all supporters" %}</a> | ||
| <a href="https://hosted.weblate.org/projects/" class="button border small rev inline" style="text-decoration: none;" target="_blank">{% trans "See all projects" %}</a> |
There was a problem hiding this comment.
Please avoid inline CSS (this one should not be necessary, the styling should be done by the classes).
There was a problem hiding this comment.
Yes, the inline CSS has been removed.
There was a problem hiding this comment.
I can still see it in this place (style="text-decoration: none;").
There was a problem hiding this comment.
I apologize for this, i have gotten rid of that now.
2) Testimonial has been changed to a single class. 3) Inline/excessive css has been removed. 4) Created and RTL css variant
|
I have pushed two more commits for the mentioned fixes |
| <div class="clear"></div> | ||
| <a href="https://hosted.weblate.org/projects/" class="button border small rev inline" target="_blank">{% trans "See all projects" %}</a> | ||
| <a href="{% url 'donate' %}#thanks" class="button border small rev inline">{% trans "See all supporters" %}</a> | ||
| <a href="https://hosted.weblate.org/projects/" class="button border small rev inline" style="text-decoration: none;" target="_blank">{% trans "See all projects" %}</a> |
There was a problem hiding this comment.
I can still see it in this place (style="text-decoration: none;").
Removed Inline Styling.
nijel
left a comment
nijel
left a comment
There was a problem hiding this comment.
Thanks, we're getting closer now. Besides the things I've commented separately, can you please make the CI pass. Most of the failures are caused by formatting issues, the easiest approach to that is to install pre-commit and let it do the formatting for you. See https://docs.weblate.org/en/latest/contributing/code.html#coding-standard
weblate_web/static/style.css
Outdated
| .container, | ||
| .footer, | ||
| .main, | ||
| .header { | ||
| width: 100%; | ||
| max-width: 1000px; | ||
| margin-left: auto; | ||
| margin-right: auto | ||
| } | ||
|
|
||
| @media screen and (min-width: 600px) { | ||
| .main { | ||
| display: -webkit-flex; | ||
| display: flex | ||
| } | ||
| } |
There was a problem hiding this comment.
Are these styles used? I could not find single use of "main" class.
There was a problem hiding this comment.
I have removed the useless css.
weblate_web/static/style.css
Outdated
| line-height: 23px; | ||
| text-decoration: underline; | ||
| } | ||
| .unqimg{ |
There was a problem hiding this comment.
Can you please choose a bit more descriptive class names? Neither unqimg nor contentt are easy to understand.
There was a problem hiding this comment.
Okay,let me commit the final version.
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
|
Stale on our side, sorry... |
|
Rebased on current master in #537 |
2 participants
Proposed changes
Checklist
Other information