Open
Conversation
maxim-voronko
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix double slashes in paths when
virtualDiris set to rootCloses #7
Issue
Setting
virtualDir: /orvirtualDir: ""to deploy WProofreader at the root path caused malformed double-slash paths in probe definitions and the post-install notes URL, because.Values.virtualDirwas interpolated directly into strings that already contained surroundingslashes.
Solution
Added a single reusable helper
wproofreader.virtualDirBasePathto_helpers.tplthat normalizesvirtualDirinto a consistent path prefix:"wscservice"→"/wscservice""/"or""→""(empty string)This allows all call sites to append their path suffix directly without any per-use-case branching:
Changes
templates/_helpers.tplwproofreader.virtualDirBasePathhelpertemplates/deployment.yamltemplates/NOTES.txtvalues.yamlWPR_DOMAIN_NAMEexample byWPR_JVM_MAX_MEMORY_SIZE_MBNotes
WPR_VIRTUAL_DIRenv var passed to the container is intentionally not normalized — the container accepts/and""natively.virtualDir: wscserviceare unaffected.