Skip to content

Conversation

@lulicdarko
Copy link

@lulicdarko lulicdarko commented Feb 5, 2026

Added libWPEWebInspectorResources from launcher widget .

Explanation:
The primary goal of this change is to allow the Webkit to lookup and load libWPEWebInspectorResources.so directly from a widget’s internal bundle.

Fallback Mechanism:

Check Internal: Look for resources inside the widget’s bundle.
Check External: If not found, fall back to the standard library/system path.

@modeveci modeveci requested a review from magomez February 5, 2026 10:39
@magomez
Copy link

magomez commented Feb 5, 2026

@lulicdarko when creating a PR, besides removing the default template if you're not going to use it, could provide a description of what the goal of the PR is? It's hard to review changes when you don't know what they are trying to do. Thanks!!

@modeveci
Copy link

modeveci commented Feb 5, 2026

Hi @magomez , AFAIK, this ticket is about dowloadable runtime resources to be loading proper inspector. you can consider in scope DAC (downloadable apps;ication container). Thanks

@magomez
Copy link

magomez commented Feb 5, 2026

Hi @magomez , AFAIK, this ticket is about dowloadable runtime resources to be loading proper inspector. you can consider in scope DAC (downloadable apps;ication container). Thanks

Sure. But what's the goal here? I understand that we want to be able to load libWebInspectorResouces.so from the path defined in WEBKIT_INJECTED_BUNDLE_PATH, which is the one that will contain the InjectedBundle as well?

@lulicdarko
Copy link
Author

Hello @magomez Still not ready for merge, we are running jenkins jobs in order to test all functionalities, once it is verified i will do complete update

@modeveci
Copy link

modeveci commented Feb 5, 2026

Hi @lulicdarko , could you keep the ticket as Draft when it is still in validation? That gives us a cue that we need to get your input before merging. Thank you!

@magomez
Copy link

magomez commented Feb 5, 2026

Hi @magomez , AFAIK, this ticket is about dowloadable runtime resources to be loading proper inspector. you can consider in scope DAC (downloadable apps;ication container). Thanks

Sure. But what's the goal here? I understand that we want to be able to load libWebInspectorResouces.so from the path defined in WEBKIT_INJECTED_BUNDLE_PATH, which is the one that will contain the InjectedBundle as well?

Ah, no, sorry. We'll be loading from the parent dir of the path contained in WEBKIT_INJECTED_BUNDLE_PATH

@lulicdarko lulicdarko marked this pull request as draft February 5, 2026 15:01
@lulicdarko lulicdarko marked this pull request as ready for review February 9, 2026 09:48
@lulicdarko
Copy link
Author

Hello @magomez I marked PR as ready for review.

@magomez magomez merged commit f51e896 into WebPlatformForEmbedded:wpe-2.46 Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants