Add button and shortcut to download results JSON#103
Open
sunnyps wants to merge 1 commit intoWebKit:mainfrom
Open
Add button and shortcut to download results JSON#103sunnyps wants to merge 1 commit intoWebKit:mainfrom
sunnyps wants to merge 1 commit intoWebKit:mainfrom
Conversation
✅ Deploy Preview for webkit-motionmark-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sunnyps
force-pushed
the
push-vyupswvntvpt
branch
from
1d3f4fe to
cdda051
Compare
smfr
reviewed
Mar 9, 2026
| @@ -158,6 +158,7 @@ <h1>MotionMark score</h1> | |||
| <button onclick="benchmarkController.restartBenchmark()">Test Again</button> | |||
| <p> | |||
| 'j': Show JSON results<br/> | |||
Contributor
There was a problem hiding this comment.
I think we should show small gray text that lists these shortcuts on the end screen.
Author
There was a problem hiding this comment.
I'm not sure what you mean here since we already have some text listing the shortcuts:
sunnyps
force-pushed
the
push-vyupswvntvpt
branch
from
cdda051 to
8712602
Compare
sunnyps
force-pushed
the
push-vyupswvntvpt
branch
from
8712602 to
80f97b2
Compare
Author
|
There should now be a gap between the Done and Download buttons in the main benchmark runner (after you press 'j' to show the debug info). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.