Fixes: user-disconnect event -> replaced const declaration of variable "peers" with let declaration and changed entry point of application to point to server.js instead of index.js#25
Open
akkhilaysh wants to merge 2 commits intoWebDevSimplified:masterfrom
Conversation
added 2 commits
August 29, 2020 15:40
…riable with let declaration so it can be updated with new peers as they're added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user-disconnect event -> replaced const declaration of variable "peers" with let declaration. The user-disconnect did not have any peers when triggered because "peers" was not updating due to const/final declaration.
Changed entry point of application to point to server.js instead of index.js