[spectec] AL's Ref_ok fix for redundant side-condition removal#2175
Merged
Conversation
raoxiaojia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored ref_ok for #2171 and #2174 . Also updated test expects that were not fixed yet in #2174.
@rossberg I don't have write access so created a new PR here based on #2174, as the standalone ref_ok fix doesn't work without the spec rule change due to argument number mismatch. It's fine if you prefer to cherry-pick 7ab34d5 to your other branch in case you have some work in progress there.