Skip to content

Fix crash in MinimizeRecGroups #8685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlively merged 1 commit into from
May 8, 2026
+41 −1
Merged

Fix crash in MinimizeRecGroups #8685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/passes/MinimizeRecGroups.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,10 @@ struct MinimizeRecGroups : Pass {
// generate new groups with the same shape.
std::unordered_set<RecGroup> publicGroups;
for (auto& [type, info] : typeInfo) {
typeIndices.insert({type, typeIndices.size()});
if (info.visibility == ModuleUtils::Visibility::Private) {
// We can optimize private types.
types.push_back(type);
typeIndices.insert({type, typeIndices.size()});
} else {
publicGroups.insert(type.getRecGroup());
}
Expand Down
40 changes: 40 additions & 0 deletions test/lit/passes/minimize-rec-groups.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,4 +563,44 @@
;; CHECK: (global $privateB (ref null $privateB) (ref.null none))
(global $privateB (ref null $privateB) (ref.null none))
)

;; Regression test for a bug where we crashed when comparing rec groups with
;; references to public types because we did not store type indices for public
;; types.
;; CHECK: (export "g" (global $public))
(module
(rec
;; CHECK: (rec
;; CHECK-NEXT: (type $public (sub (descriptor $desc) (struct)))
(type $public (sub (descriptor $desc) (struct)))
;; CHECK: (type $desc (sub (describes $public) (struct)))
(type $desc (sub (describes $public) (struct)))
)

;; We should not crash when comparing these identical connected components.
(rec
;; CHECK: (rec
;; CHECK-NEXT: (type $private1 (sub $public (descriptor $desc1) (struct)))
(type $private1 (sub $public (descriptor $desc1) (struct)))
;; CHECK: (type $desc1 (sub $desc (describes $private1) (struct)))

;; CHECK: (rec
;; CHECK-NEXT: (type $4 (struct))

;; CHECK: (type $private2 (sub $public (descriptor $desc2) (struct)))
(type $private2 (sub $public (descriptor $desc2) (struct)))
(type $desc1 (sub $desc (describes $private1) (struct)))
;; CHECK: (type $desc2 (sub $desc (describes $private2) (struct)))
(type $desc2 (sub $desc (describes $private2) (struct)))
)

;; CHECK: (global $use1 (ref null $private1) (ref.null none))
(global $use1 (ref null $private1) (ref.null none))
;; CHECK: (global $use2 (ref null $private2) (ref.null none))
(global $use2 (ref null $private2) (ref.null none))
;; CHECK: (global $public (ref null $public) (ref.null none))
(global $public (ref null $public) (ref.null none))
;; CHECK: (export "public" (global $public))
(export "public" (global $public))
)

Loading