Skip to content

feat: upgrade metamask-connect sdk#2514

Merged
chaitanyapotti merged 1 commit into
masterfrom
feat/metamask-connect-upgrade
Jun 8, 2026
Merged

feat: upgrade metamask-connect sdk#2514
chaitanyapotti merged 1 commit into
masterfrom
feat/metamask-connect-upgrade

Conversation

@lwin-kyaw
Copy link
Copy Markdown
Contributor

@lwin-kyaw lwin-kyaw commented Jun 8, 2026

Jira Link

Description

Upgrades @metamask/* sdk, fixing the wallet_switchEthereumChain RPC request.

How has this been tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note

Medium Risk
Touches wallet/chain-switch RPC paths and major-version MetaMask Connect bumps; behavior change is intentional but should be validated for MetaMask and account-abstraction flows.

Overview
Bumps @web3auth/no-modal / @web3auth/modal to 11.0.2 and upgrades MetaMask Connect dependencies in packages/no-modal to @metamask/connect-evm ^2.0.0, connect-multichain ^1.0.0, and connect-solana ^2.0.0, with matching package-lock.json updates (including nested installs under no-modal).

Removes the local NULL_ON_SUCCESS_METHODS workaround and simplifies providerAsMiddleware so it forwards RPC results as-is instead of coercing undefinednull for wallet_switchEthereumChain / wallet_addEthereumChain. The deleted accountAbstractionEthRpcMiddlewares.test.ts covered that behavior.

Reviewed by Cursor Bugbot for commit 3a03d20. Bugbot is set up for automated code reviews on this repo. Configure here.

@lwin-kyaw lwin-kyaw requested review from a team as code owners June 8, 2026 02:07
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web3auth-web Ready Ready Preview, Comment Jun 8, 2026 2:07am

Request Review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3a03d20. Configure here.

@chaitanyapotti chaitanyapotti merged commit dbf5bf6 into master Jun 8, 2026
7 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/metamask-connect-upgrade branch June 8, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants