Skip to content

fix: adjust QR code modal height value #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hieu-w wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: adjust QR code modal height value #2339

hieu-w wants to merge 1 commit into from
+2 −2

Conversation

@hieu-w
Copy link
Member

@hieu-w hieu-w commented Jan 19, 2026 •
edited
Loading

Motivation and Context

Jira Link:

Description

Footer in QR code screen is not display properly.
Screenshot 2026-01-19 at 15 33 54

How has this been tested?

Test with demo-sdk in both mode:
Screenshot 2026-01-19 at 15 35 25

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@vercel
Copy link

vercel bot commented Jan 19, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
web3auth-web Ready Ready Preview, Comment Jan 19, 2026 8:36am

Request Review

smgv
smgv approved these changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@smgv smgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smgv smgv smgv approved these changes

@tanguyenvn tanguyenvn Awaiting requested review from tanguyenvn

@chaitanyapotti chaitanyapotti Awaiting requested review from chaitanyapotti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hieu-w @smgv