Fix and adjust alert margins#86
Conversation
Prettier wants to collapse it even though I wanted a paragraph out of it.
9a0b153 to
8c8a937
Compare
Shiroizu
left a comment
There was a problem hiding this comment.
Is there a reason for including <></> inside the Alerts ?
|
Prettier wants to collapse it even though I wanted a paragraph out of it. If I do this: It will do a paragraph, which is semantically correct and produces the margin (since margins are on the But Prettier really wants this: Which will cause this and makes the margin missing, since the This is why I did the |
|
Maybe this pattern could be extracted to a separate component: <Alert variant="incorrect">
<></>
**English**: Servant of Evil
</Alert>
<Alert variant="correct">
<></>
**English**: His significance of existence
</Alert>--> <Incorrect line={"English: Servant of Evil"} />
<Correct line={"English: His significance of existence"} />This way we could also avoid the extra markers |
|
Such addition would introduce unnecessary complexity that is not worth the time maintaining. The Note that the component has more use, such as: <Alert variant="incorrect">
<table class="table-fixed">
<tr>
<th>Non-English</th>
<td>Machine Love</td>
</tr>
<tr>
<th>Romanized</th>
<td>Machine Love</td>
</tr>
<tr>
<th>English</th>
<td>Machine Love</td>
</tr>
</table>
</Alert>So having the Adding separate exported components ( |
This PR fixes the missing margin on the "Prioritize official translations" rule page (see example), as well as adjusting the margins on the alert, primarily to reduce it between the alert title and its description.
Preview
Before
After