fix(table): radio cell should not render in summary row series number column #4027#5106
Open
william-xue wants to merge 1 commit intoVisActor:developfrom
Open
fix(table): radio cell should not render in summary row series number column #4027#5106william-xue wants to merge 1 commit intoVisActor:developfrom
william-xue wants to merge 1 commit intoVisActor:developfrom
Conversation
… column When using summary rows with a radio selection column, the radio button was incorrectly rendered in the summary row, inconsistent with checkbox behavior which already has an isAggregation && isSeriesNumber guard to fall back to a text cell. Closes VisActor#4027
Contributor
|
请拉取最新代码 这个问题前几个版本已经修了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
修复合计行（summary row）中行序号列（series number column）的单选框（radio）意外显示的问题。
Why
Closes #4027
当表格配置了合计行且选择列为单选框类型时，合计行上会错误地渲染单选框，
而复选框类型已正确处理了这种情况（不显示）。两者行为不一致。
How
在
cell-helper.ts的 radio 分支中，仿照 checkbox 的处理方式，添加
isAggregation && isSeriesNumber判断：当处于合计行的序号列时，降级渲染为普通文本单元格，与 checkbox 行为保持一致。
Checklist