fix(types): use Partial<ITextGraphicAttribute> for TextIcon style#5104
Open
william-xue wants to merge 1 commit intoVisActor:developfrom
Open
fix(types): use Partial<ITextGraphicAttribute> for TextIcon style#5104william-xue wants to merge 1 commit intoVisActor:developfrom
william-xue wants to merge 1 commit intoVisActor:developfrom
Conversation
The TextIcon.style field was typed as ITextAttribute which: 1. Did not include fill and other graphic attributes from IGraphicAttribute 2. Required all properties to be specified (none were optional) Change to Partial<ITextGraphicAttribute> which extends both IGraphicAttribute and ITextAttribute with all properties optional, allowing partial style definitions with fill support. Closes VisActor#3967
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TextIcon.style field was typed as ITextAttribute which:
Change to Partial which extends both IGraphicAttribute and ITextAttribute with all properties optional, allowing partial style definitions with fill support.
Closes #3967
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough