Add support for exporting to Mill 1.1.x series (tests on Mill 1.1.0-RC4)#4055
Closed
Gedochao wants to merge 2 commits intoVirtusLab:mainfrom
Closed
Add support for exporting to Mill 1.1.x series (tests on Mill 1.1.0-RC4)#4055Gedochao wants to merge 2 commits intoVirtusLab:mainfrom
Gedochao wants to merge 2 commits intoVirtusLab:mainfrom
Conversation
Gedochao
force-pushed
the
feature/export-mill-1.1.0-RC4
branch
from
f53146e to
08c84b4
Compare
Gedochao
force-pushed
the
feature/export-mill-1.1.0-RC4
branch
from
08c84b4 to
db58722
Compare
Gedochao
commented
Jan 20, 2026
Comment on lines
+105
to
+108
| val launcherTag = if useLatestLaunchers then "main" else millVersion | ||
| val launcherArtifacts = Seq( | ||
| os.rel / "mill" -> s"https://github.com/com-lihaoyi/mill/raw/$millVersion/mill", | ||
| os.rel / "mill.bat" -> s"https://github.com/com-lihaoyi/mill/raw/$millVersion/mill.bat" | ||
| os.rel / "mill" -> s"https://github.com/com-lihaoyi/mill/raw/$launcherTag/mill", | ||
| os.rel / "mill.bat" -> s"https://github.com/com-lihaoyi/mill/raw/$launcherTag/mill.bat" |
Contributor
Author
There was a problem hiding this comment.
To work around com-lihaoyi/mill#6632 / com-lihaoyi/mill#6623, we will now default exported mill launchers to the main branch of the Mill repo, with the option to instead use the version tag hidden behind a flag.
Since export is probably forever an experimental endeavour, and some legacy Mill versions would require using a more recent launcher script anyway, this feels like the lesser evil here.
Gedochao
force-pushed
the
feature/export-mill-1.1.0-RC4
branch
from
db58722 to
2df7ebe
Compare
Gedochao
force-pushed
the
feature/export-mill-1.1.0-RC4
branch
from
2df7ebe to
39dd7ea
Compare
Contributor
Author
|
Superseded by #4086 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/com-lihaoyi/mill/releases/tag/1.1.0-RC4
As the
.mill.scalaformat was dropped in 1.1.0-RC1, I changed the default build file output to.millfor Mill 1.0 exports as well.We've yet to change it in the Scala CLI repo itself.