-
Notifications
You must be signed in to change notification settings - Fork 1
Restore sphinx_rtd_theme import to match BigPlanet/vspace config #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reverted the removal of sphinx_rtd_theme import and sys.path configuration.
Both BigPlanet and vspace use this exact pattern and build successfully.
Changes:
- Restored: import sphinx_rtd_theme
- Restored: sys.path.insert(0, os.path.abspath('sphinx_rtd_theme'))
- Removed the comment about using installed package
The import is needed even though it appears unused - Sphinx requires it
to locate the theme properly when using local theme directories.
This now exactly matches the working configuration in BigPlanet and vspace.
Test Results (py3.11 on ubuntu-24.04)10 tests 9 ✅ 14s ⏱️ Results for commit a9f3208. |
Test Results (py3.10 on ubuntu-24.04)10 tests 9 ✅ 14s ⏱️ Results for commit a9f3208. |
Test Results (py3.9 on ubuntu-24.04)10 tests 9 ✅ 13s ⏱️ Results for commit a9f3208. |
Test Results (py3.13 on ubuntu-24.04)10 tests 9 ✅ 14s ⏱️ Results for commit a9f3208. |
Test Results (py3.10 on ubuntu-22.04)10 tests 9 ✅ 14s ⏱️ Results for commit a9f3208. |
Test Results (py3.11 on ubuntu-22.04)10 tests 9 ✅ 15s ⏱️ Results for commit a9f3208. |
Test Results (py3.9 on ubuntu-22.04)10 tests 9 ✅ 13s ⏱️ Results for commit a9f3208. |
Test Results (py3.12 on ubuntu-24.04)10 tests 9 ✅ 15s ⏱️ Results for commit a9f3208. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 30.59% 30.59%
=======================================
Files 4 4
Lines 268 268
=======================================
Hits 82 82
Misses 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Test Results (py3.13 on ubuntu-22.04)10 tests 9 ✅ 15s ⏱️ Results for commit a9f3208. |
Test Results (py3.14 on ubuntu-24.04)10 tests 9 ✅ 17s ⏱️ Results for commit a9f3208. |
Test Results (py3.12 on ubuntu-22.04)10 tests 9 ✅ 16s ⏱️ Results for commit a9f3208. |
Test Results (py3.14 on macos-26)10 tests 9 ✅ 17s ⏱️ Results for commit a9f3208. |
Test Results (py3.13 on macos-26)10 tests 9 ✅ 17s ⏱️ Results for commit a9f3208. |
Test Results (py3.14 on ubuntu-22.04)10 tests 9 ✅ 19s ⏱️ Results for commit a9f3208. |
Test Results (py3.11 on macos-26)10 tests 9 ✅ 19s ⏱️ Results for commit a9f3208. |
Test Results (py3.10 on macos-26)10 tests 9 ✅ 18s ⏱️ Results for commit a9f3208. |
Test Results (py3.9 on macos-26)10 tests 9 ✅ 22s ⏱️ Results for commit a9f3208. |
Test Results (py3.11 on macos-15-intel)10 tests 9 ✅ 33s ⏱️ Results for commit a9f3208. |
Test Results (py3.12 on macos-15-intel)10 tests 9 ✅ 36s ⏱️ Results for commit a9f3208. |
Test Results (py3.9 on macos-15-intel)10 tests 9 ✅ 41s ⏱️ Results for commit a9f3208. |
Test Results (py3.10 on macos-15-intel)10 tests 9 ✅ 36s ⏱️ Results for commit a9f3208. |
Test Results (py3.13 on macos-15-intel)10 tests 9 ✅ 33s ⏱️ Results for commit a9f3208. |
Test Results (py3.12 on macos-26)10 tests 9 ✅ 23s ⏱️ Results for commit a9f3208. |
Test Results (py3.14 on macos-15-intel)10 tests 9 ✅ 34s ⏱️ Results for commit a9f3208. |
Reverted the removal of sphinx_rtd_theme import and sys.path configuration. Both BigPlanet and vspace use this exact pattern and build successfully.
Changes:
The import is needed even though it appears unused - Sphinx requires it to locate the theme properly when using local theme directories.
This now exactly matches the working configuration in BigPlanet and vspace.