-
Notifications
You must be signed in to change notification settings - Fork 1
Pin Sphinx to v7.x to avoid v8.x theme compatibility issues #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sphinx 8.x has breaking changes with how themes are loaded, causing 'ThemeError: no theme named sphinx_rtd_theme found' error. Changed: sphinx>=7.0.0 → sphinx>=7.0.0,<8.0.0 This pins to Sphinx 7.x which: - Is compatible with Python 3.13+ (doesn't use deprecated imghdr) - Works with the local sphinx_rtd_theme copy in docs/ - Avoids Sphinx 8.x breaking changes Error was: 'no theme named sphinx_rtd_theme found (missing theme.toml?)'
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 30.59% 30.59%
=======================================
Files 4 4
Lines 268 268
=======================================
Hits 82 82
Misses 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx 8.x has breaking changes with how themes are loaded, causing 'ThemeError: no theme named sphinx_rtd_theme found' error.
Changed: sphinx>=7.0.0 → sphinx>=7.0.0,<8.0.0
This pins to Sphinx 7.x which:
Error was: 'no theme named sphinx_rtd_theme found (missing theme.toml?)'